Peer Code Review Best Practices for Drupal Core Maintenance - Pittsburgh 2023

Discover peer code review best practices from a Drupal core maintainer in this 45-minute conference talk from Pittsburgh 2023. Learn how to foster a supportive review culture, understand decision fatigue and directed attention fatigue, and recognize distractions as accessibility issues. Explore the importance of early defect detection, analyze defect detection rates, and gain insights into handling nitpicks effectively. Acquire practical techniques for improving code reviews, including using git diff commands and essential questions to ask during the review process. Enhance your code review skills and contribute to a more efficient and supportive development environment.

Intro
I'm xjm Drupal core release manager
Foster a supportive review culture
Decision fatigue
Directed attention fatigue (DAF)
Distractions are an accessibility issue
What is defect detection?
Early defect detection matters
Defect detection rates
Why does this happen?
Handling nitpicks
How do we fix it?
git diff --color-words="."
Questions to ask during review
Summary
References